Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-connections: 47.0 -> 47.2.1 #378704

Closed

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Feb 2, 2025

The GNOME connections project is experiencing an issue with publishing their releases.

Changes in these releases look minor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron requested review from bobby285271 and a team February 2, 2025 01:55
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 2, 2025
@nix-owners nix-owners bot requested review from hedning, jtojnar and dasj19 February 2, 2025 02:03
@bobby285271
Copy link
Member

2 nits: Do you mind update commit message as follows:

and also update nixpkgs's gtk-frdp to the same commit as https://gitlab.gnome.org/GNOME/connections/-/commit/245ac8b1923a9caeb1dec7655ac9e7f2c56580e9

pname = "gnome-connections";
version = "47.0";
version = "47.2.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release is already on the download server: https://download.gnome.org/sources/gnome-connections/47/

passthru = {
updateScript = gnome.updateScript { packageName = "gnome-connections"; };
};

meta = with lib; {
homepage = "https://gitlab.gnome.org/GNOME/connections";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo was renamed.

@philiptaron philiptaron marked this pull request as draft February 8, 2025 23:34
@Chatchaton
Copy link

this pull request seems redundant now,
see: #380474

@philiptaron philiptaron deleted the gnome-connections-47.2.1 branch February 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants